ATTENTION: Modders, fix your client add-ons.

[Greek2me]

There's a large number of client-sided mods that break the game mode system. When the game mode is changed on the server, clients are supposed to rejoin the server automatically. However, many client-side mods prevent this. Make sure that your client-side add-ons don't contain code like this. BAD: Code: [Select] package example { function disconnect() { parent::disconnect(); } function disconnectedCleanup() { parent::disconnectedCleanup(); } }; GOOD: Code: [Select] package example { function disconnect(%a) { return parent::disconnect(%a); } function disconnectedCleanup(%a) { return parent::disconnectedCleanup(%a); } }; Note how that variable is passed through to the parent. This problem is preventing me from really working on an add-on of mine. If necessary I can fix the offending add-ons myself with my updater, but I'd prefer not to do that. Let me know if you have trouble fixing the problem. Thanks for your help. Edit! Let's try this instead. If you find an add-on with a problem (even if it's not yours), fix the problem, send it to me, I'll verify that it's safe, and I'll put it on the updater.

Offending Add-Ons Client_CRP Client_Dueling Client_EventFavorites Client_MiniGolf Client_Mute Client_RealisticSpace Client_TMBI GameMode_ZAPT Item_Keycard Player_Mech Script_AdminApplications Script_AutoWrench Script_Healthbar Script_ItemRotate Server_Permissions System_BlocklandEssentials System_ItemStorage System_LoadAddOn System_ReturnToBlockland System_StaticMaps Weapon_BusterGun Weapon_LaserPointer Weapon_Package_QuakeType Weapon_PortalGun Weapon_TF2BasicMelee Weapon_TF2DemoPack Weapon_TF2ScoutPack Weapon_TF2* (the rest of them) Weapon_WH40k_Imperium Support_RaycastingWeapons.cs

[Ad Bot]

[ZSNO]

I asked Ephi to fix RTB forever ago. He said he added it to his list

[Greek2me]

RTB might be one that I need to fix with the updater.

[jes00]

I wondered why I never auto rejoined servers that changed the game mode. Because I remember Badspot mentioning it.

[Jasa]

You can add Client_CRP to that list.

[Greek2me]

It actually might be easier to get a list of the offending add-on CRCs and just have Badspot CRC ban them all.

[MonkeyFunkyMonkey]

Fixing all the addons that are broken would take years wouldn't it be easier to make a script that makes you rejoin when it changes?

[Compy]

It actually might be easier to get a list of the offending add-on CRCs and just have Badspot CRC ban them all.

b-but

zapt...

[Greek2me]

Let's try this instead. If you find an add-on with a problem, fix the problem, send it to me, I'll verify that it's safe, and I'll put it on the updater.

[Crispy_]

Well top priority i'd say is to fix the original RTB, and/or da prog's rtb.

[Advanced Bot]

Interesting, no wonder why I have been issues lately.

[Pah1023]

I always wonder why that I never reconnected.
So add-ons break it? I'll keep a look out on what add-ons parent disconnect and disconnectedCleanup.

List of add-ons that I found to not parent Disconnect properly, I'll update as I come across them.

Code: [Select]

Add-on -> Script [Package]

Client_RealisticSpace -> Move Inds.cs [MoveInds]
Client_RealisticSpace -> Fabricator GUI.cs [RSC_FabberGUI]
Script_AdminApplications -> client.cs [AdminApp_Client]
System_ItemStorage -> client.cs [ISAddOn_CLPackage]
Script_AutoWrench -> client.cs [autoEvents]

If you're wondering how I found out about this, I used a little quick code I came up with.

Code: [Select]

package trace {
function disconnect(%bool) {
trace(1);
%return = Parent::disconnect(%bool);
trace(0);
return %return;
}
};
activatePackage("trace");


[jes00]

Ones I've found that aren't on the list.

System_BlocklandEssentials (not that many people have it)
Client_Dueling (not that many people have it anymore)
Client_Mute
Client_TMBI (big one)
Script_ItemRotate (my own mod, I'll fix this :P )
System_StaticMaps
Script_AdminApplications (Me and [GSF]Ghost's mod, I'll tell him to release a quick update fixing this)
Client_OrbShift (another one of Nexus' mods)
Client_CRP
All Support_RaycastingWeapons.cs files, which are in TF2 weapons + Item_KeyCard

[Greek2me]

Added master list. Fix whatever you can and submit them!

[Ipquarx]

Fixed Client_CRP and Client_RealisticSpace

https://mega.co.nz/#!q94xnSKZ!hN1Ep-V_GX8X_F2WeSE8xS_jwvm29lXEwX4GXesXKks