Author Topic: Group.add(); doesn't add the object to the group. - Solved. My bad. (Read 1136 times)

Pie Crust · October 12, 2015, 02:12:56 AM

So I was fooling around with scriptGroups and I decided it would be a good alternative to the funky garbage I was doing before to check if a brick was being planted inside certain bounds.

So I've got this:

Code: [Select]

function inBounds(%brick) {
	%client = %brick.client;
	if(isObject(%client.lastBound)) 
		if(isInBox(%brick,%client.lastBound))
			return %client.lastBound;
	for(%i = 0;%i < $LotGroup.getCount;%i++) {
		if(isInBox(%brick,$LotGroup.getObject(%i))) {
			%client.lastBound= $LotGroup.getObject(%i);
			return %client.lastBound;
		}
	}
	return 0;
}

(yes, for the first time in my life I am indenting code)

So that should check if the brick that was planted (via an onPlant package) inside the bounds. Now, on the other hand, I have this.

Code: [Select]

function fxDTSBrick::onPlant(%brick) {
	Parent::onPlant(%brick);
	if(!%brick.getDatablock().isBounds && inBounds(%brick) == 0) {
		%brick.schedule(0,"delete");
		return;
	}
	
	if(%brick.getDatablock().isBounds){
		$LotGroup.add(%brick);
		return;
	}
}

When I plant a brick inside of the bounds, the brick gets deleted for being out of bounds (confirmed with console echoes) and the problem is that, in inBounds();, $LotGroup.getCount(); in the For loop returns 0.

If I manually type echo($LotGroup.getCount());, it will echo 0 even when bounds are planted. The only way to add the brick is manually putting into the console $LotGroup.add(brickID); and the syntax is the same in my code and in the console's input. I could use some help with this please.

Ad Bot · Advertisement

Dannu · October 12, 2015, 02:48:12 AM

Show how you are handling setting the isBounds field on the datablock.

Pie Crust · October 12, 2015, 02:50:23 AM

Code: [Select]

datablock fxDtsBrickData(Arena_brickBoundsdata: brick64x64FData)
{
	category = "Arena";
	subcategory = "Important";
	cost=500;
	uiName = "Bounds";
	specialBrickType = "";
	isBounds= true;
	adminOnly = 0;
};

Nothing out of the ordinary. Also, this wouldn't be the issue since an echo that would be when the bounds brick is planted is being passed onto the console. (The echo was added after making the thread, fyi)

Pie Crust · October 12, 2015, 02:59:54 AM

So I changed the code to this

Code: [Select]

function fxDTSBrick::onPlant(%brick) {
	Parent::onPlant(%brick);
	%bounds = inBounds(%brick);
	echo(%bounds);
	if(!%brick.getDatablock().isBounds && %bounds == 0) {
		%brick.schedule(0,"delete");
		return;
	}
	
	if(%brick.getDatablock().isBounds){
		$LotGroup.add(%brick);
		return;
	}
}

And the console outputs the following when I press and hold my Enter button:

Code: [Select]

None of those are actual objects. isObject(); retuns false.

elm · October 12, 2015, 03:36:21 AM

Edit: nvm

boodals 2 · October 12, 2015, 09:40:02 AM

Quote from: Pie Crust on October 12, 2015, 02:12:56 AM

Code: [Select]
function inBounds(%brick) { %client = %brick.client; if(isObject(%client.lastBound)) if(isInBox(%brick,%client.lastBound)) return %client.lastBound; for(%i = 0;%i < $LotGroup.getCount;%i++) { if(isInBox(%brick,$LotGroup.getObject(%i))) { %client.lastBound= $LotGroup.getObject(%i); return %client.lastBound; } } return 0; }
$LotGroup.getCount(); in the For loop returns 0.

You are not calling $LotGroup.getCount(), you are accessing the variable getCount on $LotGroup. You forgot the ().
Idk if that will fix your overall problem.

Also that is inefficient, as every iteration it will call $LotGroup.getCount() . Instead you should either store the count in a variable before the loop; eg %count = $LotGroup.getCount(); for(%i = 0; %i < %count; %i++) { Or you could start at the end and work backwards; for(%i = $LotGroup.getCount() - 1; %i >= 0; %i--) {
The second method is slightly harder to read, but also slightly faster. Of course, it doesn't really matter in this case, as (I assume) there wont be too many objects in $LotGroup , but it's worth learning and getting used to.

Quote from: Pie Crust on October 12, 2015, 02:59:54 AM

And the console outputs the following when I press and hold my Enter button:
Code: [Select]
032552 032553 032554 -snip-
None of those are actual objects. isObject(); retuns false.

Just to be sure, you are doing the isObject() check before you delete them, right?

Pie Crust · October 12, 2015, 11:11:33 AM

That's not necessary because the deletion part is within fxDTSbrick::onRemove(); and the brick MUST exist for that to be called. .add(); has no reason to not work.

boodals 2 · October 12, 2015, 11:19:39 AM

Another thing I just noticed, you should not change the group of a brick, since they go in BrickGroups, which is a SimGroup that is created when a client joins, one per BL_ID, and all the bricks they own are placed into it.
Many brick functions rely on the brick being in that group, so by moving it you are breaking other things.

You should use a SimSet instead of a ScriptGroup (although SimSet doesn't allow you to use a custom class and stuff, and there's no ScriptSet. Use a ScriptObject with a reference to a SimSet).
An object has to be in exactly one Group, but can be in as many SimSets as you like.

Pie Crust · October 12, 2015, 11:21:14 AM

Quote from: boodals 2 on October 12, 2015, 11:19:39 AM

An object has to be in exactly one Group

Then this was the problem. I didn't know this and I was trying to add it to a second group but still won't explain about it working on the console. I'll try the simsets.

Nevermind. For some reason, I duplicated the check and it was calling the one at the top of the code while I was editing the one at the bottom of the code.