Is this script written correctly?

[Parallel]

I recently took a scripting class, and was taught how write a /kill command script. This is what I got:

Code: [Select]

function serverCmdKill(%c,%n)
{
    findClientbyname(%n);
    if(%c.isAdmin && !%n.isAdmin)
    {
       %n.player.kill();
    }
else
    {
      messageClient(%c,'',"You are not admin, you cannot kill this player");
    }
  }
Is that written right?

[Ad Bot]

[Kalphiter]

%n is just a string.
It makes no sense.

[Parallel]

%n is just a string.
It makes no sense.

I was told %c is the client and %n is the victim.

[Kalphiter]

%c is sent as the person who typed the command's client, but %n is just a string of letters.

[Parallel]

%c is sent as the person who typed the command's client, but %n is just a string of letters.

Would %player work as the victim instead of %n?

And was it spaced properly?

[Placid]

I'm assuming you didn't get the spacing part very much..
oo, found error in what i taught lawls

Code: [Select]

function serverCmdKill(%c,%n)
{
    findclientbyname(%n);
    if(%c.isAdmin && !%n.isAdmin)
    {
        %n.player.kill();
    }
    else
    {
        messageClient(%c,'',"You are not admin, you cannot kill this player.");
    }
}


[Kalphiter]

Wrong.
%n is still a string.

[HellsHero]

Needs more %n = findClientByName(%n);

[MegaScientifical]

Code: [Select]

function serverCmdKill(%c, %n) {
    %n = findclientbyname(%n);
    if(%c.isAdmin && !%n.isAdmin)
        %n.player.kill();
    else
        messageClient(%c, '', "You are not admin, you cannot kill this player.");
}

That's better...

[Plornt]

Would %player work as the victim instead of %n?

And was it spaced properly?

you can name it what ever you want as long as you are consistent with that name and findclientbyname(%n); returns another value so you have to assign it to another variable
like: %n = findclientbyname(%n);