Blockland Forums > Gallery
L.W Pianola 1 (Player Piano) -- Plays Maple Leaf Rag! [UPDATE 1.1]
Slezak:
--- Quote from: Sheath on July 15, 2011, 04:03:47 AM ---The sound boards are large plate bricks that emit the piano sound. The more there are, the louder the volume becomes. This one has 4, so each note has the sound of 4.
--- End quote ---
Hm... In the version of the build you posted, all the keys have the notes playing through the keys themselves, not the "soundboards". Might wanna check the version you uploaded.
--- Quote from: Sheath on July 15, 2011, 04:03:47 AM ---Yeah, really that is just so I can easily put the sounds onto the piano by just starting from 1 to 60 left to right. My convenience really, its not intended to be used for another build but you could since its not too hard to order the sounds from scratch. What I really should have done is named the keys more appropriately as bricks, so it is easier to make rolls. I need to post the diagram that shows how to easily make rolls. :U
--- End quote ---
Actually, the more intuitive route for musicians (the most likely group to make rolls) would have been to just use the note names. That way, they can associate a C with a C, not have to convert the numbers to the right notes (white1, 8, 15 are C; 2, 9, 16 are D; etc.)
Also, if I was the one making this soundpack (I hate using phrases like that...) I would have made it as easy as possible to pick out the right notes if somebody wanted to make custom songs. I would have picked a nice prefix like LateralPiano_ or LPiano_ and then added the note name+octave, so for example you'd have LPiano_C2.wav, LPiano_C3.wav, etc. etc. Your choice though. You're the soundpack maker here, not I.
Lastly, I apologize if I sound negative in these posts. I am just trying to give you criticism which you might be able to use to improve your already-quite-awesome build.
King Leo:
--- Quote from: Sheath on July 14, 2011, 06:48:28 PM ---I just wish I could have got the timing better, but even if I fasten up the relays they fall out of sync by milliseconds and it slowly snowballs. :c
--- End quote ---
Uhm.. I had no problem with that on my piano. I haven't looked into how your piano roll works, but it shouldn't be a problem...
Sheath:
--- Quote from: Slezak on July 15, 2011, 04:45:32 AM ---Hm... In the version of the build you posted, all the keys have the notes playing through the keys themselves, not the "soundboards". Might wanna check the version you uploaded.Actually, the more intuitive route for musicians (the most likely group to make rolls) would have been to just use the note names. That way, they can associate a C with a C, not have to convert the numbers to the right notes (white1, 8, 15 are C; 2, 9, 16 are D; etc.)
--- End quote ---
That is what I meant, since it already has the number system which is awkward.
--- Quote from: Slezak on July 15, 2011, 04:45:32 AM ---Also, if I was the one making this soundpack (I hate using phrases like that...) I would have made it as easy as possible to pick out the right notes if somebody wanted to make custom songs. I would have picked a nice prefix like LateralPiano_ or LPiano_ and then added the note name+octave, so for example you'd have LPiano_C2.wav, LPiano_C3.wav, etc. etc. Your choice though. You're the soundpack maker here, not I.
--- End quote ---
Yeah, perhaps I'll make an 88 key sound pack for public use since the current onces are very specific to the number of keys the build has.
I'll investigate that sound board problem, that is very strange... perhaps a design flaw.
--- Quote from: King Leo on July 15, 2011, 05:17:49 AM ---Uhm.. I had no problem with that on my piano. I haven't looked into how your piano roll works, but it shouldn't be a problem...
--- End quote ---
Strange, how is the sound activated on yours? Because my piano roll activates the key, which runs 3 or 5 events (forgive me I can't remember the exact number) which might be causing lag or inconsistency. I'm not sure how complex the song your piano was playing is on paper, but the timing for Maple Leaf is a bit of a bitch which might be contributing to a more obvious timing problem, as opposed to Prelude no.15 which sounds naturally chaotic.
King Leo:
--- Quote from: Sheath on July 15, 2011, 05:43:04 AM ---Strange, how is the sound activated on yours? Because my piano roll activates the key, which runs 3 or 5 events (forgive me I can't remember the exact number) which might be causing lag or inconsistency. I'm not sure how complex the song your piano was playing is on paper, but the timing for Maple Leaf is a bit of a bitch which might be contributing to a more obvious timing problem, as opposed to Prelude no.15 which sounds naturally chaotic.
--- End quote ---
I looked at the events on yours, and they are very similar to the ones I used. The only difference is that I use colored keys where you use the waterFX. That could be the solution.
I don't think the song itself is the problem. I looked at Maple Leaf myself and wanted my piano to play it, but it failed cause I didn't have enough keys. The only problem with songs with a complex structure is that the time interval between the relays is different, and you have to calculate the new delay each time. Cause I'm lazy, I did songs with steady 8/8th beat, where the interval between each note is 200 ms or so.
Sheath:
Maybe you could have a look at refining the roll. Or making a new one would be nice, I'd quite like to play a song on it from someone else using rolls. :o