Author Topic: Script crashing blockland (Read 3385 times)

RarwMuffinz · July 12, 2014, 07:59:46 PM

in ServerCMDCcyes

echo("Did we reach here? Or did it crash?"); %eval = "cityRPGData.getData(" @ %target.getBlid() @ ").value" @ %client.CropSell @ " -= " @ %client.CropSellAmnt @ ";"; echo(%eval); eval(%eval);

"Did we reach here? Or did it crash?" is the last thing to echo before blockland crashes.
I was using eval as a way to avoid stacks of ugly ifs

Ad Bot · Advertisement

Evar678 · July 12, 2014, 08:08:55 PM

cityRPGData.getData(%target.getBlid()).value[%client.CropSell] -= %client.CropSellAmnt;

Headcrab Zombie · July 12, 2014, 08:17:48 PM

Yeah there's very few cases where you need to, or even want to, use eval
You seem to be doing here as a way to not use arrays, which is strange because with Torque's stuffty array implementation and $array[1] being the same as $array1, pretty much their only purpose is to prevent you from needing to do exactly what you did.

I'm not familiar with CityRPG's code at all, but that seems a very strange way to retrieve the data (client has already been given through the getData function, why is it needed again in the array index? Are you sure the index shouldn't just be "cropSell" ?), so you may want to look into it further.

Cr�wn · July 12, 2014, 08:42:04 PM

Why are you doing
(" @ %target.getBlid() @ ")
instead of
(%target.getBlid())

You don't need to create an empty string just to put variables into it, just putting them in works fine.

RarwMuffinz · July 12, 2014, 08:43:58 PM

Quote from: Evar678 on July 12, 2014, 08:08:55 PM

cityRPGData.getData(%target.getBlid()).value[%client.CropSell] -= %client.CropSellAmnt;

That would actually work a whole lot better than what I did.

Quote from: Cr�wn on July 12, 2014, 08:42:04 PM

Why are you doing
(" @ %target.getBlid() @ ")
instead of
(%target.getBlid())

You don't need to create an empty string just to put variables into it, just putting them in works fine.

6 of one half a dozen of the other, they both have the same outcome. Unless one is more efficient that is.

Ipquarx · July 12, 2014, 08:45:51 PM

Quote from: RarwMuffinz on July 12, 2014, 08:43:58 PM

6 of one half a dozen of the other, they both have the same outcome. Unless one is more efficient that is.

Eval forces the game to compile the entered code into TS bytecode, which is very costly performance-wise.

Headcrab Zombie · July 12, 2014, 08:48:04 PM

Quote from: Ipquarx on July 12, 2014, 08:45:51 PM

Eval forces the game to compile the entered code into TS bytecode, which is very costly performance-wise.

This, plus the way you did it is a forgetton less readable than arrays

RarwMuffinz · July 12, 2014, 08:55:13 PM

I didnt know that $Array1 is equal to $Array[1] until now. That will be VERY helpful.

Cruxeis · July 12, 2014, 08:59:26 PM

Quote from: RarwMuffinz on July 12, 2014, 08:55:13 PM

I didnt know that $Array1 is equal to $Array[1] until now. That will be VERY helpful.

Also, you can use a for loop to get all of them.
Let's say you have all the way to $array[8]:
for(%i = 0; %i < 9; %i++) echo($Array[%i]);

Headcrab Zombie · July 12, 2014, 09:05:25 PM

Quote from: RarwMuffinz on July 12, 2014, 08:55:13 PM

I didnt know that $Array1 is equal to $Array[1] until now. That will be VERY helpful.

For multidimensional arrays:
$array[1,2] would be the same as $array1_2

It does have it's niche uses (Not too long ago, using the GUI editor, I gave a series of objects names in the pattern of Name<A>_<Y> so I could iterate through them in code) but for most uses you'll just be using the array format to access it

Advanced Bot · July 12, 2014, 10:47:17 PM

Same as $ArrayArray1 with $Array["Array1"]

Zapk� · July 12, 2014, 11:19:26 PM

You can also do $Array["Array 1"] which will be the same as $ArrayArray 1. Make sure you don't allow spaces or you won't be able to execute saved or exported variables.

Advanced Bot · July 13, 2014, 02:33:55 AM

Quote from: Zapk² on July 12, 2014, 11:19:26 PM

You can also do $Array["Array 1"] which will be the same as $ArrayArray_1. Make sure you don't allow spaces or you won't be able to execute saved or exported variables.

Shouldn't there be a _ ?

$trinick · July 13, 2014, 02:38:24 AM

No. Torque doesn't convert spaces to underscores with name insertion.

Headcrab Zombie · July 13, 2014, 07:13:04 AM

You should use an underscore rather than a space, because if you export and then exec it with a space, it will give a syntax error.