So like, legislation on weaponry should be metered on a basis of utility versus capacity for destruction. For instance, a handgun/shotgun has high utility for personal defense along with its destructive potential. Whereas a hand grenade has almost no utility for anyone who isn't trying to kill a large crowd of people. This is fundamentally the reason why handguns are legal and hand grenades aren't.
Bump stocks fall pretty clearly into the hand grenade category - they render the gun useless for actual defense but make it very easy to mow down a large, dense crowd of people. The only complication here is that the mechanism underlying a bump stock is essentially too simple and stupid to effectively ban. You can produce the exact same effect of a commercially-available bump stock using a good-quality rubber band.
I don't think the ban will be effective at curbing gun violence because it targets too esoteric of a problem and one which can be circumvented almost trivially by even the most incompetent would-be murderer. The idea/philosophy is right, but it's not targeting the right part of the supply.