I think HeartGold/SoulSilver will probably always be my favorite Pokemon games of all time, though SoulSilver was my first game so maybe that's why.
Generation IV is based. Platinum + HG/SS have insane amounts of gameplay they never stop giving.