Blockland Files > Add-Ons
Vehicle Events - V2 - OnVehicleTouch and a few outputs.
Svenne:
--- Quote from: Trader on March 02, 2009, 11:41:04 PM ---Failed:
TorqueScript onVehicleTouch events (i.e. detecting vehicle collisions using TorqueScript instead of in the engine) are not acceptable.
--- End quote ---
Explain why it is so bad, or noone will care.
Trader:
--- Quote from: Svenne on March 03, 2009, 04:32:16 AM ---Explain why it is so bad, or noone will care.
--- End quote ---
This Add-On basically uses a method of vehicle detection that Trigun used previously in an Add-On that was also failed. It involves running a function on a schedule, several times a second that searches around every vehicle in the server to see if any bricks are near. There's not even a guarantee that the vehicle is actually colliding with the brick because of the way this check works. This check is based on the bounding box of the vehicle, which is almost never the same size as the vehicle's collision mesh. So, not only do you have a persistent schedule running the entire time the server is alive, you also have a detection method that isn't accurate. The only way to get an accurate, efficient onVehicleTouch event is to have Badspot expose the engine's vehicle collision functionality (onCollision, etc) to TorqueScript. You're just going to have to wait for him to add this functionality, because I'm going to fail any Add-On that offers an TorqueScript-based onVehicleTouch event.
Tom:
This isn't the only mod that uses constant schedules.
Trader:
--- Quote from: Tom on March 03, 2009, 08:35:46 AM ---This isn't the only mod that uses constant schedules.
--- End quote ---
I am aware of that. The constant schedule is only part of why this Add-On was failed. It's more a question of what's being done on that schedule.
chilmans:
--- Quote from: Trader on March 03, 2009, 08:41:47 AM ---I am aware of that. The constant schedule is only part of why this Add-On was failed. It's more a question of what's being done on that schedule.
--- End quote ---
Your trying to say that you put this in fail-bin because it might lag? (Didn't ment this sentence mean)
Well, you put me on your side.