Banhammer

[Amade]

Problem solved

[Ad Bot]

[Kalphiter]

Code: (Torque) [Select]

function BanHammerImage::OnMount(%this, %obj)
{
   Parent::OnMount(%this, %obj);
   %client = %obj.client;
   if(%client.isAdmin)
   {
      if($Pref::BanHammer::SuperAdminOnly && (!%client.isSuperAdmin))
      {
         %client.player.unMountImage("BanHammerImage");//We end up here if the player isn't a super admin
      }
      else
      {
         centerPrint(%this, "This tool is Super Admin only!", 3, 2);
      }
   }
}
Read the comment

[Amade]

Oops... The pref was false. That probably had something to do with it. And it will only display the print message if they are a non-admin. I'll look at that some more.

What about the second function?

[Kalphiter]

A non-super admin would pass true for the first function
Oh, I didn't see the %client.admin there

Code: (Torque) [Select]

function BanHammerImage::OnMount(%this, %obj)
{
    %client = %obj.client;
    if(%client.isAdmin)
    {
if($Pref::BanHammer::SuperAdminOnly && (!%client.isSuperAdmin))
    %client.player.unMountImage("BanHammerImage");

else
    centerPrint(%this, "This tool is Super Admin only!", 3, 2);

return;
    }

   Parent::OnMount(%this, %obj);
}
It would try to mount before it reaches the admin check.
And you would need a return too.


I also suggest using multiple's of four for formatting(use 4 spaces and tabs)

[Amade]

Well, here's what I have right now, I'm pretty sure it works.

Code: [Select]

function BanHammerImage::OnMount(%this, %obj)
{
   %client = %obj.client;
   Parent::OnMount(%this, %obj);
   {
      if($Pref::BanHammer::SuperAdminOnly && (!%client.isSuperAdmin)) //pref is true and client is not super admin?
      {
         %client.player.unMountImage("BanHammerImage"); //this is true, unmount, display message:
         centerPrint('', 'This tool is for Super Admins only.', '');
      }
      else //if that didn't stop it...
      {
         if(!%client.isAdmin) //check for not normal admin
         {
            %client.player.unMountImage("BanHammerImage"); //if not, unmount, display message:
            centerPrint('', 'This tool is for Admins only.', '');
      }
   }
}Where would I need a return;?

[Kalphiter]

I not only explained it but already posted the correct code.
I'll fix for new code

[Kalphiter]

Code: (Torque) [Select]

function BanHammerImage::OnMount(%this, %obj)
{
    %client = %obj.client;

    if($Pref::BanHammer::SuperAdminOnly && !%client.isSuperAdmin) //pref is true and client is not super admin?
    {
  %client.player.unMountImage("BanHammerImage"); //this is true, unmount, display message:
centerPrint('', 'This tool is for super admins only.', '');
    }

    else if(!%client.isAdmin) //if it's not an admin
    {
%client.player.unMountImage("BanHammerImage"); //if not, unmount, display message:
centerPrint('', 'This tool is for admins only.', '');
    }

    else
Parent::OnMount(%this, %obj);
}

[Amade]

All right.
Can you see what the problem is in the second part of the script?

[Destiny/Zack0Wack0]

The first arg on servercmdban needs to be %obj.client, the person whos using the weapon.

[Amade]

All right, got it all figured out.