Chatbot Help

[PurpleMetro]

Code: [Select]

package chatbot
{
function clientCmdChatMessage(%a,%b,%c,%fmsg,%cp,%name,%cs,%fmsg)
{
parent::clientCmdChatMessage(%a,%b,%c,%fmsg,%cp,%name,%cs,%fmsg);
}
if(%msg $= "Alchbot, test active")
{
if(%name $= "Alchemy")
{
commandToServer('messageSent',"AlchBot: Activity Test Succeed!");
}
};
activatePackage(Chatbot);The packaging for my code works, but when I say the line, it does nothing. Please help.

[Ad Bot]

[Munkey]

You are ending the function early.

[PurpleMetro]

You are ending the function early.

What do you mean, Should I place the string check in the clientCmdChatMessage function?

[Lugnut]

What do you mean, Should I place the string check in the clientCmdChatMessage function?

yes.

congratulations on being a newby scripter with perfect indentation.

[PurpleMetro]

It still doesn't work :c

[Treynolds416]

yes.

congratulations on being a newby scripter with perfect indentation.

He's been trying to learn how to script for a while now

[Lugnut]

It still doesn't work :c

post your current code.

He's been trying to learn how to script for a while now

oh.

[Plornt]

The %msg variable was never defined. You probably mean %fmsg judging by parameters

[Electrk]

The %msg variable was never defined. You probably mean %fmsg judging by parameters

He also put %fmsg twice

[jes00]

This is not nessisary or anything but I suggest using if(%name $= $Pref::Player::NetName) instead because than you don't need to change the script if you change your name.

[Mold]

Code: [Select]

package chatbot
{
function clientCmdChatMessage(%a,%b,%c,%fmsg,%cp,%name,%cs,%msg)
{
parent::clientCmdChatMessage(%a,%b,%c,%fmsg,%cp,%name,%cs,%msg);
if(%msg $= "Alchbot, test active" && %name $= $Pref::Player::Netname)
{
commandToServer('messageSent',"AlchBot: Activity Test Succeed!");
}
}
};
activatePackage(Chatbot);
Fixxxxxed.

[Headcrab Zombie]

You also killed his indenting, and combined the two ifs into one. Which is fine now, but if he wants to add more messages to reply too he either has to seperate them again or copy both of them.

I'd recommend checking the name first, then checking the message. That way, when you add more messages, you don't need to add more name checks.

[PurpleMetro]

One question, I want to add in support for asking my Alchbot my current status, such as my health, what should I put to return my health value? Is health supposed to be a field/area in the player datablock?

I changed the script a little bit, I set a global string for the owner's name, so checking the name would be easier. It turns out it works

[PurpleMetro]

I've added a random number feature, but it doesn't work, please help

Code: [Select]

//"Alchemy's Person Chatbot" made by Alchemy
//This is a "Medium" script level
//This script was created for "Alchemy"

$owner = "Alchemy"
package chatbot
{
function clientCmdChatMessage(%a,%b,%c,%fmsg,%cp,%name,%cs,%msg)
{
parent::clientCmdChatMessage(%a,%b,%c,%fmsg,%cp,%name,%cs,%msg);
if(%name $= $owner && %msg $= "Alchbot, Test Active")
{
commandToServer('messageSent',"[AlchBot]: Activity Test Succeed!");
}
elseif(%name $= $owner && %msg= "Alchbot, generate a random number between "%a" and "%b"")
{
%a = 0
%b = 0
%c = (getRandom(%a,%b)
commandToServer('messageSent',"[Alchbot]: The number returned was "@ %c @"");
}
};
activatePackage(Chatbot);

[Ipquarx]

You have a lot of serious syntax errors there, and quite a few logic errors.

Wall of text incoming

syntax errors: you forgot to put a semicolen at the end of line 5, you forgot a closing brace on line 14/15, you forgot to put a space between else and if on line 15, you used = to compare 2 values when = is to set a variable (you should've used $=), you improperly used the if statement at "alchbot, generate a [...]", it isn't for formatting an input string, it's for checking values, and even if it did work like that you would've reset it at lines 17 and 18, on which you forgot to put semicolens at the end of, meaning more syntax errors, you put an extra ( on line 19 and again forgot a semicolen, and on line 20 you put @ "" for some reason, idk why.

so about 15 syntax errors