String Manipulation [causes strange crash]

[Honorabl3]

This is my first time seriously diving deeper in manipulating a string. The following code cuts out a set of specified words from a range. The problem that I seem to be having, is that Blockland crashes whenever the following function is used. (executes fine)

Code: [Select]

function TC_lovetract(%msg, %phrase)
{
%dp = strpos(%phrase, "-");
%lw = getSubStr(%phrase, (%dp + 1), 1);
%fw = getSubStr(%phrase, 0, (%dp - 1));
%wc = getWordCount(%msg);
for(%a=0;%a<%wc;%a++)
{
if(getWord(%msg, %a) $= %fw)
%fwl = %a;

else if(getWord(%msg, %a) $= %lw)
%lwl = %a;

if(%a >= 30)
return error("Stopping endless loop!");
}

return getWords(%msg, 0, (%fwl - 1)) SPC getWords(%msg, (%lwl + 1), %wc);
}
If you don't mind, please tell me what I did wrong.

[Ad Bot]

[Port]

Add echos at various points in your code and use setLogMode(1); , then run your function and check console.log after Blockland crashed.

[Greek2me]

Why change the log mode? All that does is close the file after it writes each line.

[Port]

Why change the log mode? All that does is close the file after it writes each line.

If you don't do that, the echos from your function won't reach console.log before the game crashes.

[Honorabl3]

I placed three echo tests in the function, all displayed in console before crashing.

[Greek2me]

I placed three echo tests in the function, all displayed in console before crashing.

Then apparently it is after those three echos.

[elm]

Can you return the error function like that? Lol, what does that function even return?

[Treynolds416]

Can you return the error function like that? Lol, what does that function even return?

The point is that it breaks out of the extraction function and errors at the same time. What I don't understand is why you have the possibility of an endless loop. Is there any situation when %wc wouldn't be correctly defined

[Zeblote]

Can you return the error function like that? Lol, what does that function even return?

It will say something about using return value of void function call in the console

[Honorabl3]

I added that stop to the loop originally because I thought it was crashing from the loop somehow; going on forever.

[Greek2me]

I added that stop to the loop originally because I thought it was crashing from the loop somehow; going on forever.

Add more echos to check.

[Xalos]

Is it possible the string is becoming larger than 4095 characters long? Supposedly that crashes Blockland (although in my experience that only happens if you DISPLAY a string that long).

[Honorabl3]

Is it possible the string is becoming larger than 4095 characters long? Supposedly that crashes Blockland (although in my experience that only happens if you DISPLAY a string that long).

I've had weird instances where my script doesn't cause Blockland to crash. But, that's when I am only experimenting it on small strings. Although, when I try to recreate them - it sometimes doesn't work?

[Xalos]

I've had weird instances where my script doesn't cause Blockland to crash. But, that's when I am only experimenting it on small strings.

Weird instances that follow a pattern are not weird instances. Try echoing the strLen of the string at various points in the function.

[Honorabl3]

RESULTS:





So by my understanding, what is causing this thing to crash:
- It is either incorrectly executing the ending return.
- Echo'ing the results are causing it to crash. - Tested it without echo'ing it, seems to crash as-well.

More edits:

Code: [Select]

return getWords(%msg, 0, (%fwl - 1)) SPC getWords(%msg, (%lwl + 1), %wc);%fwl, and/or %lwl is being defined wrongly. Edit: Which also means that %fw, and %lw could be defined wrongly.

More important update with question:

%phrase = "dealer-is";
%dp = 6;

Code: [Select]

%lw = strchr(%phrase, (%dp + 1));It seems the code above doesn't define %lw correctly. As %lw isn't being defined at all.