System add-on I'll release soon. Added toggle walk/run and server keybinds!

[Greek2me]

i want the add-on to punch holes in it

i don't actually have the time to test functionality, just read code

I want to review the code, too, if that's ok.

[Ad Bot]

[Mr_Doom]

I want to review the code, too, if that's ok.

Would love to do that myself too

[Aide33]

Would love to do that myself too

Code would be nice yeah

[DrenDran]

Make features toggleable

Yeah, sure.

and make event saves deleteable ingame

Already done.

Also you know when you start the game, the RTB notifications overlap that "next" and "go!" buttons in the start server screen? Can you make a feature that replaces/disables notifications?

I'm not going to mod RTB.
No way Ephi would like that.

Thanks for the bump, by the way.

I want to review the code, too, if that's ok.

Would love to do that myself too

Code would be nice yeah

One thing I can tell you all is that it doesn't use eval.
It uses the call function function, which cannot have code injected into it.

[Port]

One thing I can tell you all is that it doesn't use eval.
It uses the call function function, which cannot have code injected into it.

call("eval", "..."); !!1

But anyway, I'd appreciate getting to review it too, not so much just for security holes but also mainly just for optimization and general bloat.

[MARBLE MAN]

call("eval", "..."); !!1

But anyway, I'd appreciate getting to review it too, not so much just for security holes but also mainly just for optimization and general bloat.

I noticed that too, let me see if I can fix it real quick.I could add that.Sure. Though if I remember correctly I had it filter out all semicolons, that should render it harmless.
edit: doesn't even use eval anymore:

Code: [Select]

function BLRS_AuthCommand(%sender,%command,%arg1,%arg2,%arg3)
{
if(isFunction("blrscmd" @ %command))
{
call("blrscmd" @ %command,%sender,%arg1,%arg2,%arg3);
}
//old bad way of doing it
//eval("blrscmd" @ %command @ "(" @ %sender @ ",\"" @ %arg1 @ "\",\"" @ %arg2 @ "\",\"" @ %arg3 @ "\");");
}


[LagoomSack]

i wannda beta test

[Zeblote]

Why does everyone want to read this add-on's code

[Lugnut]

i think port was sarcastic

Why does everyone want to read this add-on's code

i did because it previously had some security flaws allowing brute force and remote authenticated eval injection