Firstly. I still think these functions are incredibly useless, as you're just being too lazy to type a little bit more.
function fcbn(%client)
{findclientbyname(%client);}
function msg(%client, %msg)
{messageClient(%client, '', %msg);}
You also haven't tested this. Plus you've failed to fix some of the things mentioned.
In serverCmdDonate:
The first variable(
%bl) is never used(does not matter much, it's just useless code).
The second variable(
%hostN) will always be blank because
$TSoE::Host is blank. Although that doesn't matter much because that variable is never used either.
The third variable(
%host) will always be blank. As you can see when you define it:
%host = fcbn(%host);
It will always be blank because you're defining it with
%host, which is already blank. To find the host's client you'll have to go through
clientGroup and do various checks to see if they're the host.
In serverCmdLink:
All messages you attempt to send to the host won't work because
%host does not exist. You don't even attempt to define it in this function.
You're still erasing all server preferences when you export your sponsor and donator global variables.
When a donator joins the server their status still won't load because you're calling
AutoDonatorCheck with
%this.client instead of
%this. Look at the function name:
GameConnection::AutoAdminCheck(%this)GameConnection is the class name for a client. Meaning that
%this is the client.
Also.
In the link command the link won't be displayed in hyperlinks.
