Author Topic: Code crashes blockland (Read 868 times)

KozzyMoto · July 23, 2016, 10:45:48 PM

This little punk bit of code crashes blockland when used.

This is the whole thing

function serverCmdKick(%client, %playername)
{
        // The host kick works fine so I'm ignoring it
	if(isHost(%client)) // Skip the crap below if host
	{
		serverCmdKick(%client, findclientbyname(%playername));
	}
	if(%client.isModerator || %client.isAdmin || %client.isSuperAdmin)
	{
		%player = findClientByName(%playername);
		if(%player.isModerator || %player.isAdmin || %player.isSuperAdmin) // If the player is staff, don't kick
		{return messageClient(%client,'',"\c6You can't kick that player!");}
		serverCmdKick(%client, findclientbyname(%playername));
	}
}

This part in specific is what I think is causing the problem, but why it is I don't know

Code: [Select]

if(%client.isModerator || %client.isAdmin || %client.isSuperAdmin) // if client is staff continue
	{
		%player = findClientByName(%playername);
		if(%player.isModerator || %player.isAdmin || %player.isSuperAdmin) // If the player is staff, don't kick
		{return messageClient(%client,'',"\c6You can't kick that player!");}
		serverCmdKick(%client, findclientbyname(%playername));
	}

Ad Bot · Advertisement

Paperwork · July 23, 2016, 11:11:30 PM

You're calling serverCmdKick() within itself, thereby causing an infinite loop which crashes Blockland.

If you want to disconnect a player from the server, you can try using %client.delete("reason"); instead - I don't know what the native function is for actually kicking a player in Blockland or if there's a better way entirely but I can't check at the moment.

I also don't know if serverCmdKick() is already a default function in Blockland, but if it is then I don't think you should be overwriting it.

KozzyMoto · July 23, 2016, 11:19:48 PM

Ah, okay.

What if I did this?

Code: [Select]

package Pack
{

    function serverCmdKick(%client, %playername)
    {
        Parent::serverCmdKick(%client, findclientbyname(%playername));
    }

};

Conan · July 23, 2016, 11:23:40 PM

kicking using .delete(); is valid; if you put a string as a parameter, its shown to the player

eg %client.delete("Spamming"); will show the "You have been disconnected from the server" dialog box with "Spamming" underneath the first line.

and servercmdkick does exist.
your new code looks fine

KozzyMoto · July 23, 2016, 11:26:05 PM

are you sure serverCmdKick doesn't exist?

When I use the host kick

Code: [Select]

if(isHost(%client)) // Skip the crap below if host
{
	serverCmdKick(%client, findclientbyname(%playername));
}

It kicks the player and puts in the chat
Player kicked Player (Id:55555)

Hawt · July 23, 2016, 11:29:05 PM

it is a default function

you can probably scrap the permission checks and replace it with

Code: [Select]

if(%client.getBLID() != getNumKeyID()) and tell them that they aren't allowed to use it since otherwise unless isHost is a defined function it won't work